CVS log for downtime.c

Up to [DownTime]

Request diff between arbitrary revisions - Display revisions graphically

Keyword substitution: kv
Default branch: MAIN

Primary and secondary text according to the GNOME HIG in dialogs

Clean up dialogs, try to set parets of modal warning / error dialogs... Haven't been able to do it nicely everywhere, particularly in storage.c.

  - Fixed Save as / Open filter
  - File associations - double-clicking a saved .downtime file file launch DownTime with those settings. If auto_run was specified, a shutdown will be launched immediately
  - Tray icon, enabled by default when a shutdown is pending
  - Remove the "Remember these settings" check box - We now always remember the last shutdown in the user's .downtime file, but don't auto-save to any other loader file
  - Disable File->Save if we can't write to the current config file

  - File->Save As, wherein one can specify that the saved file should auto-run. Still need to fix file filter
  - Support "auto_run" tag in saved configuration files launched via DownTime to automatically start a specified shutdown

*** empty log message ***

Remove previously added pointless statement...

Correctly restart argument parsing with va_copy()

- 0.3.2!
- Bump copyright date

Reset the variable argument pointer in pasprintf() as one vsnprintf() call clobbers the current position.

Don't quite understand why this never appeared to be a problem on x86, but now DownTime should work on amd64, too.

- Progress bar behaves (at least more) correctly under pausing
- Break out some info nto separate header files
- Kill cat_strings, replace with pasprintf() where appropriate
- Style and miscellaneous small clean-ups

Bump copyright date and replace another "AUTHOR" with "THE AUTHOR(S)"

Use "'\0'" rather than "(char) NULL" when referring to the NUL character

  - Bump copyright dates and change "AUTHOR" to "THE AUTHOR(S)" in various source files
  - "Always on top" setting for the progress window works
  - Allow for specifying a configuration file as the first command-line parameter. Thisd could be helpful if people have multiple regular shutdown regimens they use and (for example) wish to set up different shortcuts for them

  - "Close" button on "About" dialog now closes the dialog as expected
  - Preferences dialog, with "Always on top" settings for both main dialog and progress dialog
  - Makefile sets X11BASE to /usr/local if not defined
  - Global window and sub-element structures. Geez I wish GTK callbacks allowed for multiple user parameters to be passed...
  - Miscellaneous cleanups / relatively minor changes

Initial work on Preferences dialog and Advanced main dialog view

No longer use the non-standard err() and warn() functions / their peers

- No more settings struct. We now have a shutdown_t struct, which holds information relevant to the shutdown process, a user_specs struct, which holds all directly user-specified information, and two global variables: config_path and shutdown_path (both of type char *). Many changes have been made to incorporate these changes
- Further passing of variables rather than accessing them externally. Note that we're passing the new specs struct to functions that you would normally expect not to require it (e.g., get_user_specs()). This is because there may be more stored in specs in the future than just stuff displayed in the main window
- load_user_specs() (formerly load_settings()) now only modifies settings on a successful call
- Better usage of macros in downtime.h for settings default user specs
- New function update_user_specs(user_specs *specs) which updates the struct pointed to by specs to reflect (at this point) the current settings in the main window
- Myriad minor improvements

- Correctly record the shutdown type specified. This corrects a recently introduced bug that would cause the shutdown type specified to only take effect on the _next_ shutdown (i.e.: Not the one the type was specified for)
- Reduced dependence on global variables

- Slight renamings. In particular, shutdown_params -> state, and the aforementioned struct's config_location parameter is now config_path
- init_state() created (and used) to initialise the global settings
- If we couldn't find the location of the configuration file, disable the ability to save / remember settings
- Graphically warn the user if there was a problem loading saved settings, unless the problem in question is simply that the file doesn't exist
- Check for non-printable characters (other than newline) when reading the configuration file
- Correctly output the configuration file name in the error dialogue which appears if we couldn't open a file specified through File -> Open

- Broke start_shutdown() apart
- Miscellaneous corrections and improvements

Improved error checking code (still needs some work, though)

- Miscellaneous cleanups / minor corrections / improvements
- Slightly improved shutdown(8) output handling and handling possibilities

- minor cleanups
- lint target in Makefile. Doesn't seem to work for me, though, as there are a horde of errors reported in GTK-related header files

 - Bump version number to 0.2.0-dev. Sufficient changes have been made, and further significant changes - including breaking configuration file compatibility with previous versions - are to come
 - New TODOs
 - Implement long int max_minutes_to_shutdown(void), which returns the maximum number of minutes until a scheduled shutdown (for instance, it will return 7 when a shutdown is to occur in 6 minutes and 3 seconds)
 - Miscellaneous cleanups
 - Start of a "shutdown_type" struct - trying to clean up the shutdown type selection menu and interactions and allow the searching of shutdown types based on name (the motivation here is the potential to specify a shutdown type in words in the DownTime configuration file. So, for instance, the following line might be common in the file: "<shutdown_type>power-off</shutdown_type>")
 - Use single bit bit-fields in the shutdown_params struct rather than char types for boolean variables to potentially converse 2 bytes on most machines

Print hours, minutes and seconds as well as the number of days to go for shutdown times longer that 1 day

Implement pause functionality

Fixed a bug whereby the shutdown path would be undefined after a File -> Open of a config

Fixed some more memory leaks.

About to do a bit of stuffing about so that when load_settings() is called we don't lose the shutdown path

- Re-implement is_in_string_array(), as it was broken and messy
- Fix a (bloody stupid) memory leak that I should be shot for :-)

Slightly less boned now, but there're still issues:
 - " Size 36" appears to get appended to the end of shutdown_param_array in shutdown.c, or at least a ps -ax | grep shutdown shows it there after launching...
 - "Bad address" back again sometimes when launching shutdown(8)... Could be related to the issue above?

Use array_add()

Remove some apparently erroneous free()s.

Believe there are memory leaks in get_filename_from_path(), but I want to replace add_to_*_array() with array_add() from Shithead before delving into it, as this will change the scenario a little

Only add the user's path if the program's setuid as another user so that a user couldn't simply create an executable called "shutdown" in a PATH location which would then be run as the setuid user (which would probably be root, if setuid is used)

Complete execute only requirement for shutdown binary across files / messages

Fix memory leaks

Fixed some erroneous free()ing

	- Reworked shutdown(8) binary discovery
	- Fixed a stuff-up in is_in_string_array() where the variable array_length would be off-by-one after termination of a loop due to erroneous decrementation of the variable's value during the loop header (or whatever the loop initialisery bit's called :-))
	- Changed is_in_string_array() to take a size_t parameter as the length of an array, rather than an int, which may not necessarily be large enough

Yet more variable fixing up

Remove an unnecessary variable, malloc(), etc.

Code cleanup, removing "p_" etc. from variable names, removed some unnecessary malloc()s

Remove debugging printf()s

Fix off-by-ones in pasprintf() and pvasprintf(): vsnprintf() prints at most length - 1 characters, so to print the full length characters we have to pass it length + 1

Implement pasprintf() and pvasprintf() as portable replacements of the asprintf() and vasprintf() functions

Revive Makefile... Need to learn a lot more about GNU autotools before I can use them effectively

- Include "config.h" in source files
- Check for asprintf() and vasprintf()

time_t appears to be a long int on Debian and a (regular) int on FreeBSD. Have therefore typecast a time_t / int to long int for consistency

- Include strings.h for GNU/Linux systems where required to be able to use index()
- #define _GNU_SOURCE on GNU/Linux systems where required to be able to use asprintf() and vasprintf() (A genuinely portable solution should be found)
- Some indenting issues fixed

Apparently sysexits.h is only available on BSD systems. Therefore, we now only include it on BSD systems, and we redefine EX_* to EXIT_FAILURE for other systems

(NOTE: Commit date wrong. Imported into CVS after release)

Version 0.1.1
  - Corrected a bug which would cause DownTime to loop for a heck of a long time trying to free() memory that wasn't allocated in the first place due to an unsigned integer underflow
  - Corrected program name in COPYRIGHT (whoops!)
  - Added license information to all C source files
  - Added CHANGELOG

(NOTE: Commit date wrong. Imported into CVS after release)

Initial, version 0.1 release!