CVS log for interface.c

Up to [DownTime]

Request diff between arbitrary revisions - Display revisions graphically

Keyword substitution: kv
Default branch: MAIN

Re-add separators in the main and progress dialogs.

Seems like standard GNOME dialogs do it...?

Top-align warning / error icons in dialogs

Primary and secondary text according to the GNOME HIG in dialogs

Interface cleanup

Clean up dialogs, try to set parets of modal warning / error dialogs... Haven't been able to do it nicely everywhere, particularly in storage.c.

Icon stuff finalised!

Icon in error window, too

Correct icon stuff (hopefully! Seems to work on FreeBSD / GNOME at least)

- Icon
- Clean up / GNOME HIG-ify some dialogs

Save with .downtime extension

Correctly save preferences

  - Fixed Save as / Open filter
  - File associations - double-clicking a saved .downtime file file launch DownTime with those settings. If auto_run was specified, a shutdown will be launched immediately
  - Tray icon, enabled by default when a shutdown is pending
  - Remove the "Remember these settings" check box - We now always remember the last shutdown in the user's .downtime file, but don't auto-save to any other loader file
  - Disable File->Save if we can't write to the current config file

  - File->Save As, wherein one can specify that the saved file should auto-run. Still need to fix file filter
  - Support "auto_run" tag in saved configuration files launched via DownTime to automatically start a specified shutdown

File->Save is enabled / disabled too

free() existing specs->config_path when loading new settings

- Disable the "remember these settings" check box if there's no config file
- Proper GTK file open dialog
- Bump some dates and change dome minor things

*** empty log message ***

- 0.3.2!
- Bump copyright date

Should work on Ubuntu 8.10 (using gksudo)

Correct comments

- Progress bar behaves (at least more) correctly under pausing
- Break out some info nto separate header files
- Kill cat_strings, replace with pasprintf() where appropriate
- Style and miscellaneous small clean-ups

Bump copyright date and replace another "AUTHOR" with "THE AUTHOR(S)"

Save user preferences properly

Set window titles appropriately on all windows

Use "'\0'" rather than "(char) NULL" when referring to the NUL character

Print date and time in messages to stderr

Correct a bug whereby attempting to set preferences when no configuration file already exists (e.g., when first running DownTime) would result in a warning and non-application / saving of the new preferences

Correct a bug in closing the main window (made it in for 0.3.0)

Correctly close if we're paused and the progress dialog is closed

  - Cancel button on the close-downtime-when-a-shutdown's-in-progress-window
  - Closing the abovementioned window through the WM close button is equivalent to hitting "Cancel", rather than "No"
  - Set functions whose return value is insignificant to return void

Update incorrect function names in some error messages (there's got to be a better way of doing this)

  - Remove window structs (one could certainly argue this makes things messier, rather than the cleaner...)
  - Re-introduce File -> Open and File -> Save (A "Save As..." should be forthcoming) as they could be used nicely in conjunction with the previously introduced command-line parameter configuration file path passing

Pass multiple parameters through structs to GTK callback functions

  - Bump copyright dates and change "AUTHOR" to "THE AUTHOR(S)" in various source files
  - "Always on top" setting for the progress window works
  - Allow for specifying a configuration file as the first command-line parameter. Thisd could be helpful if people have multiple regular shutdown regimens they use and (for example) wish to set up different shortcuts for them

  - "Close" button on "About" dialog now closes the dialog as expected
  - Preferences dialog, with "Always on top" settings for both main dialog and progress dialog
  - Makefile sets X11BASE to /usr/local if not defined
  - Global window and sub-element structures. Geez I wish GTK callbacks allowed for multiple user parameters to be passed...
  - Miscellaneous cleanups / relatively minor changes

Initial work on Preferences dialog and Advanced main dialog view

No longer use the non-standard err() and warn() functions / their peers

"Close" button on "About" dialog now closes the dialog as expected

Stylistic changes only

WIFEXITED () takes an int, not an (int *)

Much stuffing about with gtk_main() / gtk_main_quit() etc., across a variety of functions to ensure correct window operation

select_and_open_config() was instructing the GTK to pass a reference to the OK button of the file selection dialog, whereas what we wanted was a reference to the file_selection object itself - corrected

- No more settings struct. We now have a shutdown_t struct, which holds information relevant to the shutdown process, a user_specs struct, which holds all directly user-specified information, and two global variables: config_path and shutdown_path (both of type char *). Many changes have been made to incorporate these changes
- Further passing of variables rather than accessing them externally. Note that we're passing the new specs struct to functions that you would normally expect not to require it (e.g., get_user_specs()). This is because there may be more stored in specs in the future than just stuff displayed in the main window
- load_user_specs() (formerly load_settings()) now only modifies settings on a successful call
- Better usage of macros in downtime.h for settings default user specs
- New function update_user_specs(user_specs *specs) which updates the struct pointed to by specs to reflect (at this point) the current settings in the main window
- Myriad minor improvements

- Correctly record the shutdown type specified. This corrects a recently introduced bug that would cause the shutdown type specified to only take effect on the _next_ shutdown (i.e.: Not the one the type was specified for)
- Reduced dependence on global variables

Juxtapose declarations of automatic variables in display_progress()

- Slight renamings. In particular, shutdown_params -> state, and the aforementioned struct's config_location parameter is now config_path
- init_state() created (and used) to initialise the global settings
- If we couldn't find the location of the configuration file, disable the ability to save / remember settings
- Graphically warn the user if there was a problem loading saved settings, unless the problem in question is simply that the file doesn't exist
- Check for non-printable characters (other than newline) when reading the configuration file
- Correctly output the configuration file name in the error dialogue which appears if we couldn't open a file specified through File -> Open

- Broke start_shutdown() apart
- Miscellaneous corrections and improvements

load_settings() now returns status information.

About to look at settings (i.e., the shutdown_params struct) and passing between functions

- Improve shutdown(8) output handling greatly. DownTime will now no longer wait indefinitely for shutdown(8) to output a PID
- If we couldn't find the shutdown(8) PID, disable the pause button in the progress dialog, don't keep checking whether the process is active (can't, don't know it's PID, assuming it exists) and don't prompt to terminate a shutdown on DownTime exit
- START_SHUTDOWN_PID_OUTPUT is now defined in downtime.h for easier manipulation, given that it's likely to change across platforms

 - Bump version number to 0.2.0-dev. Sufficient changes have been made, and further significant changes - including breaking configuration file compatibility with previous versions - are to come
 - New TODOs
 - Implement long int max_minutes_to_shutdown(void), which returns the maximum number of minutes until a scheduled shutdown (for instance, it will return 7 when a shutdown is to occur in 6 minutes and 3 seconds)
 - Miscellaneous cleanups
 - Start of a "shutdown_type" struct - trying to clean up the shutdown type selection menu and interactions and allow the searching of shutdown types based on name (the motivation here is the potential to specify a shutdown type in words in the DownTime configuration file. So, for instance, the following line might be common in the file: "<shutdown_type>power-off</shutdown_type>")
 - Use single bit bit-fields in the shutdown_params struct rather than char types for boolean variables to potentially converse 2 bytes on most machines

- Use GtkComboBoxs rather than GtkOptionMenus
- Mark quite a few functions static
- Change a few GTK callback functions to return type void rather than gboolean when we weren't returning anything useful
- display_settings() is now update_main()
- update_main() (formerly display_settings()) is used to apply the appropriate values in the relevant areas of the main window when it's first created

More cleanup

Clean up

Explicitly set the timeout units to minutes when manipulating settings.timeout as a time in minutes

- Update the actual timeout value that shutdown(8) will be called with after a pause. This will round the time left up to the nearest minute (shutdown(8) is not able to cope with to-the-minute timings on any platform that I know of)
- If a user hits "Close" on the shutdown progress dialog whilst a shutdown is paused, don't confirm that they want to terminate the shutdown

This will be in version 0.1.3

Implement pause functionality

Fixed a bug whereby the shutdown path would be undefined after a File -> Open of a config

Fixed some more memory leaks.

About to do a bit of stuffing about so that when load_settings() is called we don't lose the shutdown path

Fixed a formatting string bug when outputting the unexpected termination of shutdown(8) in unknown cercimstances whereby the PID would be suffixed by the character 'l'

Code cleanup, removing "p_" etc. from variable names, removed some unnecessary malloc()s

Implement pasprintf() and pvasprintf() as portable replacements of the asprintf() and vasprintf() functions

Revive Makefile... Need to learn a lot more about GNU autotools before I can use them effectively

- Include "config.h" in source files
- Check for asprintf() and vasprintf()

- Include strings.h for GNU/Linux systems where required to be able to use index()
- #define _GNU_SOURCE on GNU/Linux systems where required to be able to use asprintf() and vasprintf() (A genuinely portable solution should be found)
- Some indenting issues fixed

Include stdio.h for asprintf() & co.

Apparently sysexits.h is only available on BSD systems. Therefore, we now only include it on BSD systems, and we redefine EX_* to EXIT_FAILURE for other systems

Removed double-adding of save_menu_item in create_main()

(NOTE: Commit date wrong. Imported into CVS after release)

Version 0.1.1
  - Corrected a bug which would cause DownTime to loop for a heck of a long time trying to free() memory that wasn't allocated in the first place due to an unsigned integer underflow
  - Corrected program name in COPYRIGHT (whoops!)
  - Added license information to all C source files
  - Added CHANGELOG

(NOTE: Commit date wrong. Imported into CVS after release)

Initial, version 0.1 release!