CVS log for storage.c

Up to [DownTime]

Request diff between arbitrary revisions - Display revisions graphically

Keyword substitution: kv
Default branch: MAIN

Primary and secondary text according to the GNOME HIG in dialogs

Clean up dialogs, try to set parets of modal warning / error dialogs... Haven't been able to do it nicely everywhere, particularly in storage.c.

  - Fixed Save as / Open filter
  - File associations - double-clicking a saved .downtime file file launch DownTime with those settings. If auto_run was specified, a shutdown will be launched immediately
  - Tray icon, enabled by default when a shutdown is pending
  - Remove the "Remember these settings" check box - We now always remember the last shutdown in the user's .downtime file, but don't auto-save to any other loader file
  - Disable File->Save if we can't write to the current config file

  - File->Save As, wherein one can specify that the saved file should auto-run. Still need to fix file filter
  - Support "auto_run" tag in saved configuration files launched via DownTime to automatically start a specified shutdown

free() existing specs->config_path when loading new settings

- Disable the "remember these settings" check box if there's no config file
- Proper GTK file open dialog
- Bump some dates and change dome minor things

- 0.3.2!
- Bump copyright date

Add comments indication why we're free()ing temp and not just returning it

- Progress bar behaves (at least more) correctly under pausing
- Break out some info nto separate header files
- Kill cat_strings, replace with pasprintf() where appropriate
- Style and miscellaneous small clean-ups

Bump copyright date and replace another "AUTHOR" with "THE AUTHOR(S)"

Use "'\0'" rather than "(char) NULL" when referring to the NUL character

Re-work loading user settings. Not actually convinced this is better, though it could potentially be a step in the right direction with further work...

  - Remove window structs (one could certainly argue this makes things messier, rather than the cleaner...)
  - Re-introduce File -> Open and File -> Save (A "Save As..." should be forthcoming) as they could be used nicely in conjunction with the previously introduced command-line parameter configuration file path passing

  - Bump copyright dates and change "AUTHOR" to "THE AUTHOR(S)" in various source files
  - "Always on top" setting for the progress window works
  - Allow for specifying a configuration file as the first command-line parameter. Thisd could be helpful if people have multiple regular shutdown regimens they use and (for example) wish to set up different shortcuts for them

  - "Close" button on "About" dialog now closes the dialog as expected
  - Preferences dialog, with "Always on top" settings for both main dialog and progress dialog
  - Makefile sets X11BASE to /usr/local if not defined
  - Global window and sub-element structures. Geez I wish GTK callbacks allowed for multiple user parameters to be passed...
  - Miscellaneous cleanups / relatively minor changes

No longer use the non-standard err() and warn() functions / their peers

Consistent handling of a badly stored timeout parameter. Just warn on stdout and continue parsing

- No more settings struct. We now have a shutdown_t struct, which holds information relevant to the shutdown process, a user_specs struct, which holds all directly user-specified information, and two global variables: config_path and shutdown_path (both of type char *). Many changes have been made to incorporate these changes
- Further passing of variables rather than accessing them externally. Note that we're passing the new specs struct to functions that you would normally expect not to require it (e.g., get_user_specs()). This is because there may be more stored in specs in the future than just stuff displayed in the main window
- load_user_specs() (formerly load_settings()) now only modifies settings on a successful call
- Better usage of macros in downtime.h for settings default user specs
- New function update_user_specs(user_specs *specs) which updates the struct pointed to by specs to reflect (at this point) the current settings in the main window
- Myriad minor improvements

- Correctly record the shutdown type specified. This corrects a recently introduced bug that would cause the shutdown type specified to only take effect on the _next_ shutdown (i.e.: Not the one the type was specified for)
- Reduced dependence on global variables

Remove debug message

- Slight renamings. In particular, shutdown_params -> state, and the aforementioned struct's config_location parameter is now config_path
- init_state() created (and used) to initialise the global settings
- If we couldn't find the location of the configuration file, disable the ability to save / remember settings
- Graphically warn the user if there was a problem loading saved settings, unless the problem in question is simply that the file doesn't exist
- Check for non-printable characters (other than newline) when reading the configuration file
- Correctly output the configuration file name in the error dialogue which appears if we couldn't open a file specified through File -> Open

- Broke start_shutdown() apart
- Miscellaneous corrections and improvements

Fix a potential memory leak in an error condition

load_settings() now returns status information.

About to look at settings (i.e., the shutdown_params struct) and passing between functions

Only warn on stdout if we couldn't open the DownTime configuration file rather than presenting a graphical warning. This is because this event will always happen when DownTime is first run by a user and it's not that big a deal anyway

- Don't call umask(2) when opening the configuration file for reading
- Only warn about not being able to open the configuration file if load_settings() was told to do so

Improved error checking code (still needs some work, though)

- Miscellaneous cleanups / minor corrections / improvements
- Slightly improved shutdown(8) output handling and handling possibilities

- Instead of writing the value of an enum member to the configuration file for the "timeout_unit" and "shutdown_type", write a string describing the desired setting. Though this requires more effort to deal with and more execution time, it makes up for it in the robustness stakes. That having been said, it's still a bit messy and I can't help but feel that an array of structs with a number and parameter name each might help provide a better solution
- Correctly report negative shutdown timeout

 - Bump version number to 0.2.0-dev. Sufficient changes have been made, and further significant changes - including breaking configuration file compatibility with previous versions - are to come
 - New TODOs
 - Implement long int max_minutes_to_shutdown(void), which returns the maximum number of minutes until a scheduled shutdown (for instance, it will return 7 when a shutdown is to occur in 6 minutes and 3 seconds)
 - Miscellaneous cleanups
 - Start of a "shutdown_type" struct - trying to clean up the shutdown type selection menu and interactions and allow the searching of shutdown types based on name (the motivation here is the potential to specify a shutdown type in words in the DownTime configuration file. So, for instance, the following line might be common in the file: "<shutdown_type>power-off</shutdown_type>")
 - Use single bit bit-fields in the shutdown_params struct rather than char types for boolean variables to potentially converse 2 bytes on most machines

- Do checking to ensure that the configuration file location was actually found. Averts a potential NULL-pointer dereference if getpwuid() was unsuccessful
- Log the version of DownTime a configuration file was last written by
- static things up a little

Implement pause functionality

Fixed a bug whereby the shutdown path would be undefined after a File -> Open of a config

Slightly less boned now, but there're still issues:
 - " Size 36" appears to get appended to the end of shutdown_param_array in shutdown.c, or at least a ps -ax | grep shutdown shows it there after launching...
 - "Bad address" back again sometimes when launching shutdown(8)... Could be related to the issue above?

Use array_add()

Code cleanup, removing "p_" etc. from variable names, removed some unnecessary malloc()s

Implement pasprintf() and pvasprintf() as portable replacements of the asprintf() and vasprintf() functions

Revive Makefile... Need to learn a lot more about GNU autotools before I can use them effectively

- Include "config.h" in source files
- Check for asprintf() and vasprintf()

- Include strings.h for GNU/Linux systems where required to be able to use index()
- #define _GNU_SOURCE on GNU/Linux systems where required to be able to use asprintf() and vasprintf() (A genuinely portable solution should be found)
- Some indenting issues fixed

Apparently sysexits.h is only available on BSD systems. Therefore, we now only include it on BSD systems, and we redefine EX_* to EXIT_FAILURE for other systems

(NOTE: Commit date wrong. Imported into CVS after release)

Version 0.1.1
  - Corrected a bug which would cause DownTime to loop for a heck of a long time trying to free() memory that wasn't allocated in the first place due to an unsigned integer underflow
  - Corrected program name in COPYRIGHT (whoops!)
  - Added license information to all C source files
  - Added CHANGELOG

(NOTE: Commit date wrong. Imported into CVS after release)

Initial, version 0.1 release!